[Flexible-schema] Refactor gql query runner to emit api event before processing to gql types #8596
+1,254
−1,052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…processing to gql types
| { | ||
| filter: { id: { eq: args.id } }, | ||
| }, | ||
| return this.executeQuery<UpdateOneResolverArgs<Partial<T>>, T>( |
There was a problem hiding this comment.
remove this executeQuery layer
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR moves API event emission logic from GraphqlQueryRunnerService to individual resolver services, ensuring events contain raw database records before GraphQL processing occurs.
- Removed event emission from
GraphqlQueryRunnerServiceand distributed to individual resolver services likeGraphqlQueryCreateManyResolverService - Events now emit after record formatting but before GraphQL processing in all resolver services to prevent unwanted nesting/formatting
- Removed
removeGraphQLAndNestedPropertiesmethod fromApiEventEmitterServiceto pass raw records directly - Added consistent fetching of existing records before updates to properly track changes
- Standardized event emission timing across all resolvers (create/update/destroy) to occur post-formatting but pre-GraphQL processing
7 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
...es/twenty-server/src/engine/api/graphql/graphql-query-runner/graphql-query-runner.service.ts
Outdated
Show resolved
Hide resolved
...ine/api/graphql/graphql-query-runner/resolvers/graphql-query-create-many-resolver.service.ts
Outdated
Show resolved
Hide resolved
...ine/api/graphql/graphql-query-runner/resolvers/graphql-query-update-many-resolver.service.ts
Outdated
Show resolved
Hide resolved
Comment on lines
84
to
88
| const nonFormattedUpdatedObjectRecords = await queryBuilder | ||
| .update(data) | ||
| .where({ id: args.id }) | ||
| .returning('*') | ||
| .execute(); |
There was a problem hiding this comment.
logic: Transaction needed to ensure atomicity between read and update operations
...nty-server/src/engine/api/graphql/graphql-query-runner/services/api-event-emitter.service.ts
Show resolved
Hide resolved
…vent-emit-before-gql-processing
…vent-emit-before-gql-processing
| }); | ||
| } | ||
|
|
||
| async; |
charlesBochet
approved these changes
Nov 21, 2024
charlesBochet
deleted the
c--refactor-graphql-query-runner--move-api-event-emit-before-gql-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8300
Context
API events were created too late and were already formatted as Gql responses (including nesting with edges/node/type + formatting that should not exist in an event payload). This PR moves the emit logic to the resolver where we actually do the DB query
Note: Also added RESTORED events