Add object names to favorites #8593
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds object names to favorites in the navigation drawer, with a text overflow issue where long object names are being clipped instead of showing ellipsis.
- Added
StyledItemLabelWithObjectNameinNavigationDrawerItem.tsxbut text-overflow styling not working correctly - Added
isFavoriteandobjectNameprops to bothNavigationDrawerItemandNavigationDrawerSubItemcomponents - Implemented
CreateLabelWithObjectNameutility for proper object name formatting with capitalization - Added separator dots between favorite label and object name with proper spacing
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| const StyledItemLabelWithObjectName = styled.span` | ||
| color: ${({ theme }) => theme.font.color.light}; | ||
| font-weight: ${({ theme }) => theme.font.weight.regular}; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| `; |
There was a problem hiding this comment.
logic: Missing overflow property and max-width constraint needed for text-overflow: ellipsis to work. Add overflow: hidden and max-width.
| favorite.labelIdentifier + | ||
| ' . ' + | ||
| String(favorite.objectNameSingular?.charAt(0).toUpperCase()) + |
There was a problem hiding this comment.
logic: Inconsistent separator - using ' . ' (space-dot-space) here but ' · ' (space-middot-space) in the component render. Should use the same separator consistently.
| @@ -36,6 +37,8 @@ export const NavigationDrawerSubItem = ({ | |||
| keyboard={keyboard} | |||
| rightOptions={rightOptions} | |||
| isDraggable={isDraggable} | |||
| isFavorite | |||
There was a problem hiding this comment.
logic: Setting isFavorite to true by default may be too restrictive - consider making this configurable via props like the other properties
|
Hey @Bonapara, can you review this please? |
Closes #8549
The favorites tab now also displays the object names.
There seems to be a text overflow error with the code as it is. It is not truncating automatically leading to a "clip" behavior instead of an "ellipsis". I tried fixing that, but could not. The Object name should get truncated. Hope someone can guide me on this