Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Long text fields (textarea) #8557

Merged
merged 18 commits into from
Nov 18, 2024
Merged

Wrap Long text fields (textarea) #8557

merged 18 commits into from
Nov 18, 2024

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Nov 18, 2024

Here we add the option for Text inputs to be wrapped, and to select on how many lines text should be displayed.

Fix #7552

@guillim guillim self-assigned this Nov 18, 2024
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and tested locally. Looks good so far, I have an issue with the preview though, see screenshot
Screenshot 2024-11-18 at 16 12 11

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Weiko Weiko merged commit 2f3c416 into main Nov 18, 2024
19 checks passed
@Weiko Weiko deleted the feature-7552 branch November 18, 2024 16:36
Copy link
Contributor

Thanks @guillim for your contribution!
This marks your 6th PR on the repo. You're top 5% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Copy link

sentry-io bot commented Nov 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Trying to use a "RICH_TEXT" field as a "TEXT" field. Verify that the field is defined as a type "... /object/task/fefe53d5-2dc4-492d-89e1-71e8bd8d4ff9 View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Wrap Long text fields (textarea)
2 participants