Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flaky storybook test #8515

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Improve flaky storybook test #8515

merged 3 commits into from
Nov 15, 2024

Conversation

FelixMalfait
Copy link
Member

I don't think that will solve the flaky test but at least it will cleanup the error message to avoid confusion

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates test assertions and mock data structure to improve Storybook test reliability and error messaging clarity.

  • Changed findByText to findAllByText in /packages/twenty-front/src/pages/object-record/__stories__/RecordIndexPage.stories.tsx to handle multiple instances of 'Companies' text
  • Updated company mock data structure in /packages/twenty-front/src/testing/mock-data/companies.ts with detailed address fields and secondary link properties
  • Added 3000ms timeout to text assertion to reduce flakiness

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait FelixMalfait force-pushed the improve-storybook-test branch from 21e605c to b66c6dc Compare November 15, 2024 13:09
@FelixMalfait FelixMalfait merged commit 34a3a66 into main Nov 15, 2024
18 of 19 checks passed
@FelixMalfait FelixMalfait deleted the improve-storybook-test branch November 15, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant