Fix record board export not taking filters into account #8505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the record export functionality to properly handle filters when exporting records from the record board view, with improved organization of export-related hooks and components.
- Added filter support in
useExportFetchRecordsby integrating withcontextStoreFiltersandcontextStoreTargetedRecordsRule - Moved export hooks to dedicated
/exportdirectory for better code organization - Added handling of hidden kanban fields in exports when using kanban view
- Added comprehensive test coverage for both table and kanban view exports in
useExportFetchRecords.test.ts - Improved currency field handling in
useExportProcessRecordsForCSVwith proper type safety
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
added a commit
that referenced
this pull request
Nov 15, 2024
Fix Export CSV action not taking into account the filters applied on the Kanban index view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Export CSV action not taking into account the filters applied on the Kanban index view