[Workflow] Add search in variable dropdown #8479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
force-pushed
the
add-search-in-dropdown
branch
from
04d8eb4 to
261f830
Compare
martmull
force-pushed
the
add-search-in-dropdown
branch
from
261f830 to
c5fbdf3
Compare
martmull
force-pushed
the
add-search-in-dropdown
branch
from
d876080 to
c07dc56
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds search functionality to variable dropdowns and improves their UI, including transparent backgrounds and updated icons for better visual consistency.
- Added search input with case-insensitive filtering in
SearchVariablesDropdownStepSubItem.tsx - Introduced
transparentBackgroundprop in/packages/twenty-front/src/modules/ui/layout/dropdown/components/StyledDropdownButtonContainer.tsxfor nested UI elements - Modified
/packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuHeader.tsxpadding and width for better search input accommodation - Replaced IconVariable with IconVariablePlus in
/packages/twenty-ui/src/display/icon/components/TablerIcons.ts - Added
hasMaxHeightprop to DropdownMenuItemsContainer for improved scrolling behavior
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| isUnfolded ? theme.background.transparent.light : theme.background.primary}; | ||
| background: ${({ theme, isUnfolded, transparentBackground }) => | ||
| transparentBackground | ||
| ? 'none' |
There was a problem hiding this comment.
style: 'none' and 'transparent' used inconsistently between normal and hover states. Should use 'transparent' in both places for consistency.
Comment on lines
+53
to
+57
| const filteredOptions = searchInputValue | ||
| ? options.filter(([key]) => | ||
| key.toLowerCase().includes(searchInputValue.toLowerCase()), | ||
| ) | ||
| : options; |
There was a problem hiding this comment.
style: Consider debouncing the filter operation for better performance with large option sets
thomtrp
approved these changes
Nov 14, 2024
khuddite
pushed a commit
to khuddite/twenty
that referenced
this pull request
Nov 18, 2024
- fix Icon variable Plus - add search input - fix dropdown height ## Before  ## After 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After