Fix style #8475
Merged
Fix style #8475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
force-pushed
the
fix-nested-fields-workflow-action-design
branch
from
7dd8b3e to
d6437de
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved the visual design and layout of workflow action forms, focusing on better organization and readability of nested fields.
- Added
noMarginprop toHorizontalSeparatorin/packages/twenty-front/src/modules/auth/sign-in-up/components/HorizontalSeparator.tsxfor flexible spacing control - Enhanced nested field containers in
/packages/twenty-front/src/modules/workflow/components/WorkflowEditActionFormServerlessFunction.tsxwith background, borders, and proper spacing - Increased label font size from 'xs' to 'md' in
/packages/twenty-front/src/modules/workflow/search-variables/components/VariableTagInput.tsxfor better readability - Added visual separation between root-level fields using
HorizontalSeparatorfor clearer form structure
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| width: 100%; | ||
| `; | ||
|
|
||
| const StyledSeparatorContainer = styled.div` | ||
| const StyledSeparatorContainer = styled.div<{ noMargin: boolean }>` |
There was a problem hiding this comment.
style: Type definition should include all props from HorizontalSeparatorProps since visible and text could be needed for styling
| @@ -13,6 +12,7 @@ import { useDebouncedCallback } from 'use-debounce'; | |||
| import { getDefaultFunctionInputFromInputSchema } from '@/workflow/utils/getDefaultFunctionInputFromInputSchema'; | |||
| import { FunctionInput } from '@/workflow/types/FunctionInput'; | |||
| import { mergeDefaultFunctionInputAndFunctionInput } from '@/workflow/utils/mergeDefaultFunctionInputAndFunctionInput'; | |||
| import { HorizontalSeparator } from 'packages/twenty-front/src/modules/auth/sign-in-up/components/HorizontalSeparator'; | |||
There was a problem hiding this comment.
style: Import path should use relative path '@/auth/sign-in-up/components/HorizontalSeparator' instead of full path
thomtrp
approved these changes
Nov 13, 2024
| ): ReactNode | undefined => { | ||
| isRoot = true, | ||
| ): ReactNode[] => { | ||
| const displaySeparator = (functionInput: FunctionInput) => { |
There was a problem hiding this comment.
could go outside the component maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After