Update zapier trigger payload #8464
Conversation
martmull
commented
Nov 12, 2024
martmull
commented
- fixes zapier tests
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the Zapier integration's trigger payload structure and improves JWT authentication handling for better consistency and reliability.
- Changed webhook operation format from
create.companytocompany.createdin/packages/twenty-zapier/src/test/triggers/trigger_record.test.ts - Added new
getOperationFromDatabaseEventActionfunction in/packages/twenty-zapier/src/creates/crud_record.tsto properly map database actions to GraphQL mutations - Modified trigger payload structure to consistently wrap data under
recordproperty across all operations - Improved JWT validation in
/packages/twenty-server/src/engine/core-modules/jwt/services/jwt-wrapper.service.tsby adding payload existence check - Standardized error handling by using
AuthExceptionconsistently for JWT validation failures
7 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| expect(firstCompany).toBeDefined(); | ||
| expect(firstCompany.id).toBeDefined(); | ||
| expect(firstCompany.record.id).toBeDefined(); | ||
| expect(Object.keys(firstCompany).length).toEqual(1); |
There was a problem hiding this comment.
logic: Inconsistent object structure check - other tests check firstCompany.record but this one checks firstCompany directly before checking firstCompany.record.id
| expect(firstCompany.record).toBeDefined(); | ||
| expect(firstCompany.updatedFields).toBeDefined(); |
There was a problem hiding this comment.
style: Test only checks that updatedFields exists but not its content or structure. Consider adding more specific assertions
| @@ -1,7 +1,5 @@ | |||
| export type InputData = { [x: string]: any }; | |||
There was a problem hiding this comment.
style: Consider using a more specific type than { [x: string]: any } for InputData to improve type safety
| updatedFields: [ | ||
| Object.keys(result).filter((key) => key !== 'id')?.[0], | ||
| ] || ['updatedField'], |
There was a problem hiding this comment.
logic: This logic will only ever return the first non-id field as the updated field, which may not be accurate if multiple fields were actually updated
