Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timeline padding #8440

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #8437

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Removed hard-coded width calculation from timeline container to fix unwanted right padding issue, ensuring proper 24px margin around the timeline content.

  • Removed width: calc(100% - ${theme.spacing(8)}) from StyledTimelineContainer in /packages/twenty-front/src/modules/activities/timeline-activities/components/EventList.tsx to rely on natural flex layout
  • Timeline container now properly respects parent padding defined in StyledMainContainer (24px/theme.spacing(6))

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thank you!

@FelixMalfait FelixMalfait merged commit 51d1305 into twentyhq:main Nov 9, 2024
13 checks passed
Copy link

github-actions bot commented Nov 9, 2024

Thanks @harshrajeevsingh for your contribution!
This marks your 11th PR on the repo. You're top 3% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted right padding on timeline
2 participants