Fix contributor website import script #8404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented database conflict handling for issue and PR labels to prevent duplicate entries in the Twenty website's GitHub data sync process.
- Added
onConflictDoNothingoption in/packages/twenty-website/src/database/database.tsto handle duplicate entries gracefully - Fixed potential null reference errors in
/packages/twenty-website/src/github/contributors/get-latest-update.tsxwith fallback date - Corrected field name from 'pullRequestId' to 'issueId' in
/packages/twenty-website/src/github/contributors/save-issues-to-db.tsx - Added type safety concern:
insertManyfunction usesanytypes in database.ts - Fixed typo in sync logging message from 'Synching' to 'Syncing'
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+13
to
+14
| ? new Date(latestPR[0].updatedAt) | ||
| : new Date('2023-01-01'); |
There was a problem hiding this comment.
style: Consider making '2023-01-01' a configurable constant at the module level since it's used multiple times and represents a business rule
| @@ -13,7 +13,7 @@ export const executePartialSync = async () => { | |||
| return new Error('No GitHub token provided'); | |||
There was a problem hiding this comment.
logic: returning new Error() doesn't handle the error - should throw or propagate it
| @@ -14,7 +14,7 @@ export const fetchAndSaveGithubData = async () => { | |||
| return new Error('No GitHub token provided'); | |||
There was a problem hiding this comment.
logic: returning Error object directly won't work as expected - should throw or return Promise.reject()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had duplicate entries in the database for issueLabels/ prLabels