Make filters work on export csv action #8389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the filter handling system to support CSV exports and record deletion by separating filter state management from record targeting logic.
- Added new
contextStoreFiltersComponentStateto manage filters independently from record selection/exclusion - Modified
computeContextStoreFiltersto accept separate filter parameter and handle empty selection cases - Updated
DeleteRecordsActionEffectanduseRecordDatato incorporate filter support for deletion and CSV export - Added test coverage for new filter handling in
computeContextStoreFilters.test.ts - Synchronized filter state between
recordIndexFiltersandcontextStoreFiltersinRecordIndexTableContainerEffect
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
...es/twenty-front/src/modules/context-store/utils/__tests__/computeContextStoreFilters.test.ts
Show resolved
Hide resolved
...-front/src/modules/object-record/record-index/components/RecordIndexTableContainerEffect.tsx
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contextStoreFiltersComponentStateand refactorcontextStoreTargetedRecordsRuleComponentStatecomputeContextStoreFiltersto use filters when no records are selected