Update CanAccessMessageThreadService #8388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the message thread access control logic by simplifying queries and improving error handling when checking user permissions to access message channels.
- Replaced
Anyoperator withInincan-access-message-thread.service.tsto prevent errors with empty arrays - Combined visibility and ownership checks into a single query with OR conditions in
connectedAccountRepository.find() - Removed redundant messageChannel repository query and groupBy logic for more efficient access control
- Added proper type checking for
messageChannelMessageAssociationsparameter - Simplified error handling to only throw
ForbiddenExceptionwhen no matching accounts found
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...server/src/modules/messaging/common/query-hooks/message/can-access-message-thread.service.ts
Show resolved
Hide resolved
charlesBochet
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #7830