Fix npx nx run start (twenty:server:worker was not triggered) #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified the start script in package.json to properly sequence the startup of server components using concurrently, ensuring the worker process initializes after the main server is ready.
- Added concurrent execution of server/front-end and worker processes in
package.json - Implemented port 3000 availability check before worker startup
- Fixed missing
twenty:server:workertrigger innpx nx run startcommand
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -350,7 +350,7 @@ | |||
| "version": "0.2.1", | |||
| "nx": {}, | |||
| "scripts": { | |||
| "start": "npx nx run-many -t start worker -p twenty-server twenty-front" | |||
| "start": "npx concurrently --kill-others 'npx nx run-many -t start -p twenty-server twenty-front' 'npx wait-on tcp:3000 && npx nx run twenty-server:worker'" | |||
There was a problem hiding this comment.
style: Consider using nx's built-in dependency graph instead of wait-on for more reliable service orchestration
There was a problem hiding this comment.
Does not work since both command rely on one the same build nx target dependency
charlesBochet
approved these changes
Nov 7, 2024
|
Thanks @guillim for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
twenty:server:worker was not triggered in npx nx run start