Be able to specify front port #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Nov 7, 2024
lucasbordeau
commented
- Added REACT_APP_PORT in front .env
- Use value if specified otherwise 3001 by default
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds configuration flexibility by allowing users to specify a custom front-end server port through the REACT_APP_PORT environment variable.
- Added port configuration in
/packages/twenty-front/vite.config.tswith fallback to 3001 - Missing port number validation for valid range (1-65535)
- No error handling for invalid port number conversion
- Environment variable example missing from
/packages/twenty-front/.env.example - Port configuration logic could conflict with
getDefaultUrl()in/packages/twenty-front/src/config/index.tswhen determining server URL
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| } = env; | ||
|
|
||
| const port = isNonEmptyString(REACT_APP_PORT) ? parseInt(REACT_APP_PORT) : 3001; |
There was a problem hiding this comment.
logic: parseInt() could return NaN for invalid numbers. Add validation for port range (1-65535) and handle invalid input.
| @@ -17,8 +18,11 @@ export default defineConfig(({ command, mode }) => { | |||
| VITE_BUILD_SOURCEMAP, | |||
| VITE_DISABLE_TYPESCRIPT_CHECKER, | |||
| VITE_DISABLE_ESLINT_CHECKER, | |||
| REACT_APP_PORT | |||
There was a problem hiding this comment.
update self-hosting-var + front .env-example
charlesBochet
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.