Integration test : Sync mode + db reset option + cleaning #8376
Conversation
and add the option to run it without db reset
guillim
added
scope: backend
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR significantly modifies the integration testing setup and removes numerous test files to streamline the testing process.
- Added
maxWorkers: 1injest-integration.config.tsto run tests sequentially, preventing race conditions - Modified CI workflow in
.github/workflows/ci-server.yamlto use newtest:integration:resettask and upload reset logs - Split integration test commands in
project.jsoninto two variants: with and without DB reset - Removed 25+ integration test files covering various resolvers (API keys, attachments, audit logs, etc.) as part of test cleanup
- Enabled previously skipped JWT auth strategy tests by changing
xdescribetodescribe
30 file(s) reviewed, 13 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
logic: Removing all attachment resolver tests leaves critical CRUD operations untested. Consider keeping essential test cases or replacing with more focused tests.
There was a problem hiding this comment.
logic: Removing all audit log integration tests without replacement could make it harder to catch bugs in audit log functionality. Consider keeping core audit log tests or documenting where this test coverage has moved.
There was a problem hiding this comment.
logic: Removing all noteTarget resolver tests leaves critical CRUD operations untested. Consider keeping core test cases or replacing with equivalent coverage.
There was a problem hiding this comment.
logic: Removing this entire test suite leaves timeline activities untested. Consider keeping core functionality tests or replacing with more focused test cases.
There was a problem hiding this comment.
logic: Removing all view field integration tests creates a significant test coverage gap. Need confirmation that these scenarios are covered elsewhere or rationale for removing this coverage.
There was a problem hiding this comment.
logic: Removing this entire test suite eliminates coverage for critical view sort operations. Consider keeping core functionality tests even during cleanup.
There was a problem hiding this comment.
logic: Removing this entire test suite leaves critical view functionality untested. These tests covered CRUD operations, soft deletion, and data integrity checks. Consider keeping a simplified version if cleaning up, or ensure equivalent coverage exists elsewhere.
There was a problem hiding this comment.
logic: Removing all webhook integration tests without replacement or relocation could leave critical webhook functionality untested. Ensure equivalent test coverage exists elsewhere.
packages/twenty-website/src/content/developers/backend-development/server-commands.mdx
Outdated
Show resolved
Hide resolved
|
Thanks @guillim for your contribution! |
Run the CI integrationin sync mode
and add the option to run it without db reset
cleaning all the useless integration test