fix: don't use previous view group state when creating a new view #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the Kanban view creation logic to ensure new views always start with fresh view groups based on current field options, rather than inheriting groups from the source view.
- Modified
packages/twenty-front/src/modules/views/hooks/useCreateViewFromCurrentView.tsto remove view group copying from source view - Added logic to create view groups based on kanban field metadata options
- Added empty group handling with position at end of view groups array
- Ensures consistent view group creation for all new Kanban views
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+134
to
+141
| viewGroupsToCreate.push({ | ||
| __typename: 'ViewGroup', | ||
| id: v4(), | ||
| fieldValue: '', | ||
| position: viewGroupsToCreate.length, | ||
| isVisible: true, | ||
| fieldMetadataId: kanbanFieldMetadataId, | ||
| } satisfies ViewGroup); |
There was a problem hiding this comment.
style: Empty fieldValue group should have a more descriptive name like 'No Value' or 'Unassigned' for better UX
charlesBochet
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new view we don't want to use view-groups from previous view.