-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update menu title font size based on whether or not it's clickable #8354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the DropdownMenuHeader component to adjust font sizes based on clickability, implementing different sizes for clickable dropdowns versus static headers according to Figma designs.
- Bug: StartIcon variant in
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenuHeader.tsx
doesn't pass onClick to StyledHeader, causing incorrect font sizing - Font size logic in StyledHeader uses onClick prop to determine size: small (theme.font.size.sm) for clickable headers, medium (theme.font.size.md) for non-clickable ones
- Added hover background effect only for clickable headers using onClick prop in StyledHeader component
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Log
|
Fixes #8350
Summary
https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36424-125120&node-type=instance&t=psxuagFLo1Cu26Vz-0
Based on Figma, the menu header should have
base/medium
instead ofsmall/medium
when it's not clickable or dropdown. However, for dropdowns, we should keep it assmall/medium
. Menu items should stay asbase/regular
.Solution
Utilized
onClick
prop to decide the font size of the menu header. That way, Dropdowns stay asbase/small
while non-clickable headers are updated tobase/medium
Screenshots
please check out font size and weight for each case
header:
menu item:
dropdown: