8304 - Fix Action Menu Buttons Alignment #8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes UI alignment issues in the action menu by adjusting button positioning and removing unnecessary wrapper elements.
- Added
StyledActionMenuConfirmationModalswithposition: absolutein/packages/twenty-front/src/modules/action-menu/components/ActionMenuConfirmationModals.tsxto fix button alignment - Removed redundant fragment wrapper (
<></>) aroundRecordShowActionMenuin/packages/twenty-front/src/pages/object-record/RecordShowPage.tsxto eliminate unwanted gap after "more" button
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+5
to
+7
| const StyledActionMenuConfirmationModals = styled.div` | ||
| position: absolute; | ||
| `; |
There was a problem hiding this comment.
style: Using absolute positioning without specifying top/left/right/bottom coordinates could cause positioning issues in different viewport sizes
packages/twenty-front/src/modules/action-menu/components/ActionMenuConfirmationModals.tsx
Show resolved
Hide resolved
| import styled from '@emotion/styled'; | ||
|
|
||
| const StyledActionMenuConfirmationModals = styled.div` | ||
| position: absolute; |
charlesBochet
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8304
The position of the modal container wasn't absolute, so the gap was also applied after the
ShowPageMoreButton