Fix 0.32 bis #8346
Merged
Fix 0.32 bis #8346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesBochet
commented
Nov 5, 2024
| @@ -126,7 +126,7 @@ const StyledButton = styled.button< | |||
| ? `0 0 0 3px ${theme.accent.tertiary}` | |||
| : 'none'}; | |||
| color: ${!disabled | |||
| ? theme.font.color.secondary | |||
| ? theme.font.color[variant] | |||
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR includes styling refinements to navigation drawer components and icon button theming, focusing on consistent button sizing and color management.
- Removed explicit sizing from
NavigationDrawerCollapseButton, deferring toIconButton's built-in dimensions - Updated text color in
IconButtonto use variant-specific theme colors instead of hardcoded 'secondary' for secondary/tertiary variants - Reorganized imports in
NavigationDrawerHeader.tsxfor better code organization - Added proper theme-based color inheritance for button variants in
IconButtoncomponent
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various UI fixes according to discussions with Design team