fix: when field metadata SELECT type is edited update view groups #8344
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| import { Injectable } from '@nestjs/common'; | ||
|
|
||
| import { In } from 'typeorm'; | ||
|
|
||
| import { | ||
| FieldMetadataComplexOption, | ||
| FieldMetadataDefaultOption, | ||
| } from 'src/engine/metadata-modules/field-metadata/dtos/options.input'; | ||
| import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity'; | ||
| import { isSelectFieldMetadataType } from 'src/engine/metadata-modules/field-metadata/utils/is-select-field-metadata-type.util'; | ||
| import { TwentyORMGlobalManager } from 'src/engine/twenty-orm/twenty-orm-global.manager'; | ||
| import { ViewGroupWorkspaceEntity } from 'src/modules/view/standard-objects/view-group.workspace-entity'; | ||
| import { ViewWorkspaceEntity } from 'src/modules/view/standard-objects/view.workspace-entity'; | ||
|
|
||
| type Differences<T> = { | ||
| created: T[]; | ||
| updated: { old: T; new: T }[]; | ||
| deleted: T[]; | ||
| }; | ||
|
|
||
| @Injectable() | ||
| export class FieldMetadataRelatedRecordsService { | ||
| constructor( | ||
| private readonly twentyORMGlobalManager: TwentyORMGlobalManager, | ||
| ) {} | ||
|
|
||
| public async updateRelatedViewGroups( | ||
| oldFieldMetadata: FieldMetadataEntity, | ||
| newFieldMetadata: FieldMetadataEntity, | ||
| ) { | ||
| if ( | ||
| !isSelectFieldMetadataType(newFieldMetadata.type) || | ||
| !isSelectFieldMetadataType(oldFieldMetadata.type) | ||
| ) { | ||
| return; | ||
| } | ||
|
|
||
| const view = await this.getFieldMetadataView(newFieldMetadata); | ||
|
There was a problem hiding this comment. style: Consider wrapping all database operations in a transaction to ensure atomicity |
||
|
|
||
| const { created, updated, deleted } = this.getOptionsDifferences( | ||
| oldFieldMetadata.options, | ||
| newFieldMetadata.options, | ||
| ); | ||
|
|
||
| const viewGroupRepository = | ||
| await this.twentyORMGlobalManager.getRepositoryForWorkspace<ViewGroupWorkspaceEntity>( | ||
| newFieldMetadata.workspaceId, | ||
| 'viewGroup', | ||
| ); | ||
|
|
||
| const maxPosition = view.viewGroups.reduce( | ||
| (max, viewGroup) => Math.max(max, viewGroup.position), | ||
| 0, | ||
| ); | ||
|
|
||
| /** | ||
| * Create new view groups for the new options | ||
| */ | ||
| const viewGroupsToCreate = created.map((option, index) => | ||
| viewGroupRepository.create({ | ||
| fieldMetadataId: newFieldMetadata.id, | ||
| fieldValue: option.value, | ||
| position: maxPosition + index, | ||
| isVisible: true, | ||
| viewId: view.id, | ||
| }), | ||
| ); | ||
|
|
||
| await viewGroupRepository.insert(viewGroupsToCreate); | ||
|
|
||
| /** | ||
| * Update existing view groups for the updated options | ||
| */ | ||
| for (const { old: oldOption, new: newOption } of updated) { | ||
| const viewGroup = view.viewGroups.find( | ||
| (viewGroup) => viewGroup.fieldValue === oldOption.value, | ||
| ); | ||
|
|
||
| if (!viewGroup) { | ||
| throw new Error('View group not found'); | ||
| } | ||
|
There was a problem hiding this comment. style: Error should include more context like fieldMetadataId and fieldValue to help debugging |
||
|
|
||
| await viewGroupRepository.update( | ||
| { | ||
| id: viewGroup.id, | ||
| }, | ||
| { | ||
| fieldValue: newOption.value, | ||
| }, | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Delete view groups for the deleted options | ||
| */ | ||
| const valuesToDelete = deleted.map((option) => option.value); | ||
|
|
||
| await viewGroupRepository.delete({ | ||
| fieldMetadataId: newFieldMetadata.id, | ||
| fieldValue: In(valuesToDelete), | ||
| }); | ||
| } | ||
|
|
||
| private getOptionsDifferences( | ||
| oldOptions: (FieldMetadataDefaultOption | FieldMetadataComplexOption)[], | ||
| newOptions: (FieldMetadataDefaultOption | FieldMetadataComplexOption)[], | ||
| ) { | ||
| const differences: Differences< | ||
| FieldMetadataDefaultOption | FieldMetadataComplexOption | ||
| > = { | ||
| created: [], | ||
| updated: [], | ||
| deleted: [], | ||
| }; | ||
|
|
||
| const oldOptionsMap = new Map( | ||
| oldOptions.map((option) => [option.id, option]), | ||
| ); | ||
| const newOptionsMap = new Map( | ||
| newOptions.map((option) => [option.id, option]), | ||
| ); | ||
|
|
||
| for (const newOption of newOptions) { | ||
| const oldOption = oldOptionsMap.get(newOption.id); | ||
|
|
||
| if (!oldOption) { | ||
| differences.created.push(newOption); | ||
| } else if (oldOption.value !== newOption.value) { | ||
| differences.updated.push({ old: oldOption, new: newOption }); | ||
| } | ||
| } | ||
|
|
||
| for (const oldOption of oldOptions) { | ||
| if (!newOptionsMap.has(oldOption.id)) { | ||
| differences.deleted.push(oldOption); | ||
| } | ||
| } | ||
|
|
||
| return differences; | ||
| } | ||
|
|
||
| private async getFieldMetadataView( | ||
| fieldMetadata: FieldMetadataEntity, | ||
| ): Promise<ViewWorkspaceEntity> { | ||
| const viewRepository = | ||
| await this.twentyORMGlobalManager.getRepositoryForWorkspace<ViewWorkspaceEntity>( | ||
| fieldMetadata.workspaceId, | ||
| 'view', | ||
| ); | ||
|
|
||
| return await viewRepository.findOneOrFail({ | ||
| where: { | ||
| kanbanFieldMetadataId: fieldMetadata.id, | ||
| }, | ||
| relations: ['viewGroups'], | ||
| }); | ||
|
There was a problem hiding this comment. logic: Add error handling if view is not found for the given kanbanFieldMetadataId |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity'; | ||
|
|
||
| export const isSelectFieldMetadataType = ( | ||
| type: FieldMetadataType, | ||
| ): type is FieldMetadataType.SELECT => { | ||
| return type === FieldMetadataType.SELECT; | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope this is not equivalent :p typeORM makes two queries for a findOne and one for find!