Fixed expandable list and navigation menu #8336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses UI bugs in the navigation and dropdown components by improving scrolling behavior and dropdown positioning.
- Added
ScrollWrappercomponents inMainNavigationDrawerItems.tsxandCurrentWorkspaceMemberFavorites.tsxto enable proper scrolling in navigation menus - Changed
DropdownMenuheight from '100%' to 'auto' inDropdownMenu.tsxfor better content fitting - Implemented
FloatingPortalandshift()middleware inExpandedListDropdown.tsxto prevent dropdowns from going off-screen - Modified dropdown placement to 'bottom-start' for consistent positioning
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| }} | ||
| Icon={IconSettings} | ||
| /> | ||
| <ScrollWrapper contextProviderName="navigationDrawer"> |
There was a problem hiding this comment.
style: ScrollWrapper added here only wraps Search and Settings items, but other navigation sections remain outside scroll context. Consider if other sections need scrolling support too.
packages/twenty-front/src/modules/navigation/components/MainNavigationDrawerItems.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+59
to
+61
| anchorElement | ||
| ? Math.max(220, anchorElement.getBoundingClientRect().width) | ||
| : undefined |
There was a problem hiding this comment.
style: getBoundingClientRect() could cause layout thrashing if called frequently. Consider memoizing this value if the anchorElement changes often.
packages/twenty-front/src/modules/navigation/components/MainNavigationDrawerItems.tsx
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release 0.32