Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation padding on mobile devices #8318

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

khuddite
Copy link
Contributor

@khuddite khuddite commented Nov 4, 2024

close #8086

  • Technical explanation of the issue
    The mobile documentation pages have a fixed width of 340px, regardless of the device. And they are centered horizontally, so the horizontal padding is determined automatically.

  • Explanation of the fix
    I've updated the styling of those pages to use fixed padding 32px instead and let it determine the width (deviceWidth - 64px).

  • Screenshots

CleanShot 2024-11-04 at 15 01 59
CleanShot 2024-11-04 at 15 02 23

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the documentation page layout on mobile devices by adjusting padding and width constraints for better responsiveness.

  • Removed fixed width of 340px in /packages/twenty-website/src/app/_components/docs/DocsContent.tsx and /packages/twenty-website/src/app/_components/docs/DocsMain.tsx
  • Added consistent 32px padding on both sides for mobile devices (max-width: 450px)
  • Content width now dynamically adjusts based on device width minus padding (64px total)
  • Consolidated React imports to include useState in a single import statement

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Perfect :)

@FelixMalfait FelixMalfait merged commit 545cfbd into twentyhq:main Nov 7, 2024
10 of 11 checks passed
Copy link

github-actions bot commented Nov 7, 2024

Thanks @khuddite for your contribution!
This marks your 2nd PR on the repo. You're top 17% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation padding is too large on Mobile
2 participants