Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent isDisabled prop from passing to DOM in Settings/Security Link #8317

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: Prevent isDisabled prop from passing to DOM in Settings/Security Link #8317

merged 2 commits into from
Nov 6, 2024

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #8297

greptile-apps[bot]
greptile-apps bot reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed React warning in Settings/Security tab by preventing invalid DOM attribute propagation.

  • Added shouldForwardProp option to StyledLink in /packages/twenty-front/src/modules/settings/security/components/SettingsSSOIdentitiesProvidersListCard.tsx to filter out isDisabled prop
  • Maintains existing disabled functionality through pointer-events CSS property

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

FelixMalfait
FelixMalfait approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FelixMalfait FelixMalfait merged commit 2d6b239 into twentyhq:main Nov 6, 2024
17 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Thanks @harshrajeevsingh for your contribution!
This marks your 9th PR on the repo. You're top 4% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@FelixMalfait FelixMalfait FelixMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in devtools while checking Security tab
2 participants
@harshrajeevsingh @FelixMalfait