Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation on Select field #8316

Merged
merged 9 commits into from
Nov 14, 2024
+96 −204
Merged

validation on Select field #8316

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b9ad92
changed api keys to api values
ketanMehtaa Nov 4, 2024
9be6cb6
Merge branch 'main' of https://github.com/ketanMehtaa/twenty into cha…
ketanMehtaa Nov 4, 2024
a27d0fc
Improve algo
FelixMalfait Nov 8, 2024
57b3924
Improve
FelixMalfait Nov 11, 2024
2442146
Merge branch 'main' into change_label_API_keys_To_API_values
FelixMalfait Nov 11, 2024
4701a8d
Backend fix
FelixMalfait Nov 11, 2024
010cf80
PR Comments
FelixMalfait Nov 14, 2024
27670b2
Big rename
FelixMalfait Nov 14, 2024
0520c84
Fix test
FelixMalfait Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/settings/data-model/fields/forms/select/components/SettingsDataModelFieldSelectForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export const SettingsDataModelFieldSelectForm = ({
color={MAIN_COLORS.yellow}
/>
</StyledIconContainer>
<StyledApiKey>API keys</StyledApiKey>
<StyledApiKey>API values</StyledApiKey>
</StyledApiKeyContainer>
</motion.div>
)}
Expand Down
2 changes: 1 addition & 1 deletion ...ront/src/modules/settings/data-model/fields/forms/select/utils/getOptionValueFromLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const getOptionValueFromLabel = (label: string) => {
try {
transliteratedLabel = computeOptionValueFromLabelOrThrow(label);
} catch (error) {
return label;
return "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Returning empty string could cause validation issues if consuming code expects non-empty values. Consider throwing a more specific error or returning a sanitized default value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I sent a comment previously saying it wouldn't work. It seems it does but I don't understand why haha. Will check the code more in depth

}

return snakeCase(transliteratedLabel).toUpperCase();
Expand Down
Loading