Fix Danger CI not running #8299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified CI Utils workflow to ensure Danger.js and congratulatory messages run on every PR by removing the file-specific check constraints.
- Removed path filters that previously limited CI to only
packages/twenty-utilschanges - Inconsistent token usage between jobs:
github.tokenfor danger-js vssecrets.GITHUB_TOKENfor congratulate - Added
pull_request_targetevent trigger with appropriate security considerations - Configured concurrency settings to prevent parallel workflow runs
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
30
to
31
| env: | ||
| DANGER_GITHUB_API_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
style: Using github.token here but secrets.GITHUB_TOKEN below. Should be consistent between both jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Danger CI was not running anymore (we need it for CLA/Congrats bot)