Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Misalignment and Excessive Padding in Relation Card #8292

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

harshit078
Copy link
Contributor

@harshit078 harshit078 commented Nov 2, 2024

Description

Changes

Screenshot 2024-11-03 at 2 37 13 AM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Adjusted styling of relation cards in record detail view to improve visual alignment and spacing.

  • Modified StyledPropertyBox in RecordDetailRelationRecordsListItem.tsx with left alignment and reduced padding (2px top, 0.5px left)
  • Customized PropertyBox component to maintain consistent spacing while fixing content alignment
  • Removed excessive padding between card title and content for better visual hierarchy

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Bonapara Bonapara enabled auto-merge (squash) November 4, 2024 10:20
@lucasbordeau
Copy link
Contributor

@harshit078 Please use Fixes _PR_ in your PR description otherwise we have to manually close the related issue.

@harshit078
Copy link
Contributor Author

@lucasbordeau Sure, I'll keep that in mind from the next time 👍🏻

@Bonapara Bonapara merged commit d44f7a4 into twentyhq:main Nov 8, 2024
16 checks passed
Copy link

github-actions bot commented Nov 8, 2024

Thanks @harshit078 for your contribution!
This marks your 38th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Misalignment and Excessive Padding in Relation Card
3 participants