Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs with missing npx #8288

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Fix docs with missing npx #8288

merged 2 commits into from
Nov 3, 2024

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Nov 2, 2024

Related to #8082

Created this PR on purpose after both #8083 and #8161 were closed and respective branches were deleted by the author

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR standardizes command usage across documentation by updating frontend and backend commands to consistently use npx nx prefix instead of just nx or yarn.

  • Updated command format in packages/twenty-website/src/content/developers/frontend-development/frontend-commands.mdx from nx to npx nx run twenty-front:<command>
  • Added PostgreSQL permission notes in packages/twenty-website/src/content/developers/local-setup.mdx about using sudo -u postgres prefix
  • Added migration commands section in packages/twenty-website/src/content/developers/backend-development/server-commands.mdx for TypeORM and Workspace objects
  • Fixed inconsistent references to yarn storybook:serve:dev in Storybook test commands

3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -7,38 +7,55 @@ image: /images/user-guide/kanban-views/kanban.png
## Useful commands

These commands should be executed from packages/twenty-server folder.
From any other folder you can run `npx nx <command>` twenty-server.
From any other folder you can run `npx nx <command> twenty-server` (or `npx nx run twenty-server:<command>`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Inconsistent command format in explanation - shows <command> twenty-server but examples use run twenty-server:<command>


### First time setup

```
npx nx database:reset # setup the database with dev seeds
npx nx twenty-server database:reset # setup the database with dev seeds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Command format inconsistent with other examples - should be npx nx run twenty-server:database:reset for consistency

@@ -9,28 +9,32 @@ image: /images/user-guide/create-workspace/workspace-cover.png
### Starting the app

```bash
nx start twenty-front
npx nx start twenty-front
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Command syntax inconsistent with other commands. Should be 'npx nx run twenty-front:start' to match pattern

Comment on lines +36 to +37
npx nx run twenty-front:storybook:test # run tests # (needs yarn storybook:serve:dev to be running)
npx nx run twenty-front:storybook:coverage # (needs yarn storybook:serve:dev to be running)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Comments reference 'yarn storybook:serve:dev' but commands use 'npx nx run'. Update comments to match actual command syntax

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks! Not sure why I didn't merge it after making the fixes. I would have forgotten about it if you hadn't noticed!

@FelixMalfait FelixMalfait merged commit d350662 into twentyhq:main Nov 3, 2024
16 checks passed
@BOHEUS BOHEUS deleted the docs-npx-fix branch November 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants