Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconButton Secondary color #8286

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

BOHEUS
Copy link
Contributor

@BOHEUS BOHEUS commented Nov 2, 2024

Related to #8212

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR aims to change the IconButton component's color from tertiary to secondary, but there appears to be a discrepancy between the intended changes and the current codebase state.

  • The code in packages/twenty-front/src/modules/ui/input/button/components/IconButton.tsx already uses secondary color, suggesting the PR may be targeting an outdated version or incorrect file
  • The issue screenshots show inconsistent icon colors across the UI, indicating potential styling inconsistencies in other components using IconButton
  • The target file path in the PR (packages/twenty-ui/src/input/button/components/IconButton.tsx) differs from the actual component location in the codebase

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@FelixMalfait FelixMalfait merged commit 8b1f34d into twentyhq:main Nov 3, 2024
16 checks passed
@BOHEUS BOHEUS deleted the icon-button-secondary branch November 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants