[FIX] Add asignee and relation on task #8284
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the FieldsCard component to fix the display and editing of the Assignee field on Task show pages by correcting the relation field filtering logic.
- Fixed logical operator in
boxedRelationFieldMetadataItemsfilter from&&to||in/packages/twenty-front/src/modules/object-record/record-show/components/FieldsCard.tsx - Removed unnecessary condition check for
noteTargetswhen object is not a Note - Removed unnecessary condition check for
taskTargetswhen object is not a Task - Contains a commented out debug
console.logstatement that should be removed
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| objectNameSingular !== CoreObjectNameSingular.Note && | ||
| fieldMetadataItem.name !== 'noteTargets' && | ||
| fieldMetadataItem.name !== 'noteTargets' || | ||
| objectNameSingular !== CoreObjectNameSingular.Task && | ||
| fieldMetadataItem.name !== 'taskTargets', |
There was a problem hiding this comment.
logic: This condition has a logical error. Using || instead of && here will cause incorrect filtering of relation fields. The current logic will show all fields when either condition is false.
| @@ -55,6 +55,8 @@ export const FieldsCard = ({ | |||
| fieldMetadataItemA.name.localeCompare(fieldMetadataItemB.name), | |||
| ); | |||
|
|
|||
| // console.log(JSON.st(availableFieldMetadataItems)) | |||
There was a problem hiding this comment.
style: Remove commented out console.log statement
|
Oh I'm sorry I didn't see @charlesBochet had raised an issue, I had already fixed it right before you raised the PR here: #8280 Glad we came to the same conclusion :). Thanks a lot for the effort |
No problem @FelixMalfait. Also, if you've got some time two more of my PR's are awaiting review. 🙃 |
FIX #8248
There was a minor logical error in the
boxedRelationFieldMetadataItems. (see files changed)