Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook tests #8260

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix storybook tests #8260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d097a75
Fix TimelineActivities
thomtrp Oct 31, 2024
3a84f2f
Fix relation settings selected object
thomtrp Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ttings/data-model/fields/forms/relation/components/SettingsDataModelFieldRelationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ export const SettingsDataModelFieldRelationForm = ({
});

const selectedObjectMetadataItem = findObjectMetadataItemById(
watchFormValue('relation.objectMetadataId'),
watchFormValue(
'relation.objectMetadataId',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended in this pr @thomtrp ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it fixes the second test

initialRelationObjectMetadataItem?.id,
),
);

const isMobile = useIsMobile();
Expand Down
6 changes: 3 additions & 3 deletions packages/twenty-front/src/testing/mock-data/timeline-activities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const mockedTimelineActivities: Array<TimelineActivity> = [
properties: null,
updatedAt: '2023-04-26T10:12:42.33625+00:00',
id: '79f84835-b2f9-4ab5-8ab9-17dbcc45dda3',
linkedObjectMetadataId: '1ad72a42-6ab4-4474-a62a-a57cae3c0298',
linkedObjectMetadataId: 'e7a5e974-affc-40d5-be9f-2ba2783c21be',
linkedRecordCachedName: '',
linkedRecordId: 'ce40eca0-8f4b-4bba-ba91-5cbd870c64d3',
name: 'calendarEvent.linked',
Expand All @@ -30,7 +30,7 @@ export const mockedTimelineActivities: Array<TimelineActivity> = [
properties: null,
updatedAt: '2023-04-26T10:12:42.33625+00:00',
id: '79f84835-b2f9-4ab5-8ab9-17dbcc45dda3',
linkedObjectMetadataId: '1ad72a42-6ab4-4474-a62a-a57cae3c0298',
linkedObjectMetadataId: '3385d352-10a0-428f-9863-e52e7164b26c',
linkedRecordCachedName: '',
linkedRecordId: 'ce40eca0-8f4b-4bba-ba91-5cbd870c64d5',
name: 'message.linked',
Expand All @@ -55,7 +55,7 @@ export const mockedTimelineActivities: Array<TimelineActivity> = [
properties: null,
updatedAt: '2023-04-26T10:12:42.33625+00:00',
id: '79f84835-b2f9-4ab5-8ab9-17dbcc45dda3',
linkedObjectMetadataId: '1ad72a42-6ab4-4474-a62a-a57cae3c0298',
linkedObjectMetadataId: '25e10253-f0e1-4a6d-90e3-ad62a4b20292',
linkedRecordCachedName: 'New Task',
linkedRecordId: 'ce40eca0-8f4b-4bba-ba91-5cbd870c64d2',
name: 'linked-task.created',
Expand Down
Loading