Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sso): improve enterprise key var management #8152

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix(sso): improve enterprise key var management #8152

merged 4 commits into from
Oct 29, 2024

Conversation

AMoreaux
Copy link
Contributor

Resolve #8070

@AMoreaux AMoreaux force-pushed the fix/improve-enterprise-key-management branch from 9285195 to 42858a9 Compare October 28, 2024 17:31
FelixMalfait
FelixMalfait reviewed Oct 29, 2024
View reviewed changes
packages/twenty-front/src/pages/settings/security/SettingsSecurity.tsx
title="SSO"
description="Configure an SSO connection"
addornment={
<Tag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like in future iteration it will be worth abstraction this into something re-usable but we can do it later!

FelixMalfait
FelixMalfait approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just made a very subjective variable name change

@FelixMalfait FelixMalfait enabled auto-merge (squash) October 29, 2024 10:09
@FelixMalfait FelixMalfait merged commit 2e10070 into twentyhq:main Oct 29, 2024
14 of 15 checks passed
@magrinj magrinj mentioned this pull request Oct 31, 2024
Merged
charlesBochet pushed a commit that referenced this pull request Oct 31, 2024
@magrinj
fix: no more dashed line (#8254)
3fbd312 
Fix bug introduced by #8152 where `<Tag />` component doesn't have
dashed lines anymore.
<img width="114" alt="Screenshot 2024-10-31 at 3 10 10 PM"
src="https://github.com/user-attachments/assets/25c9cb91-7be2-407b-9f07-a3811fb2d082">
<img width="134" alt="Screenshot 2024-10-31 at 3 10 03 PM"
src="https://github.com/user-attachments/assets/c44a551f-0e02-4fd4-b779-2076df513b03">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMalfait FelixMalfait FelixMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error about missing enterprise key when entering Security tab
2 participants
@AMoreaux @FelixMalfait