Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix manual trigger output schema #8150

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Fix manual trigger output schema #8150

merged 3 commits into from
Oct 28, 2024

Conversation

thomtrp
Copy link
Contributor

@thomtrp thomtrp commented Oct 28, 2024

  • add schema for manual trigger
  • split into sub functions
  • handle case with no variables

thomtrp
thomtrp commented Oct 28, 2024
View reviewed changes
...enty-server/src/modules/workflow/workflow-builder/utils/generate-fake-object-record-event.ts
import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
import { generateFakeObjectRecord } from 'src/modules/workflow/workflow-builder/utils/generate-fake-object-record';

export const generateFakeObjectRecordEvent = <Entity>(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just moved that one to builder utils + used generateFakeObjectRecord

martmull
martmull reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, some comments though

packages/twenty-front/src/modules/workflow/search-variables/utils/getTriggerStepName.ts Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/workflow/search-variables/utils/getTriggerStepName.ts Outdated Show resolved Hide resolved
packages/twenty-front/src/modules/workflow/types/Workflow.ts Outdated Show resolved Hide resolved
@thomtrp thomtrp enabled auto-merge (squash) October 28, 2024 17:32
@thomtrp thomtrp merged commit 409def8 into main Oct 28, 2024
18 checks passed
@thomtrp thomtrp deleted the tt-fix-manual-trigger-outpout-computation branch October 28, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martmull martmull martmull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomtrp @martmull