Handle NBSP in tiptap parsing #8148
Merged
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-handle-non-breaking-space
branch
from
bf66a65
to
249b6c8
Compare
| @@ -11,7 +11,8 @@ export const parseEditorContent = (json: JSONContent): string => { | |||
| } | |||
|
|
|||
| if (node.type === 'text') { | |||
| return node.text || ''; | |||
| // Replace with regular space | |||
| return (node.text || '').replace(/\u00A0/g, ' '); | |||
There was a problem hiding this comment.
I would prefer: node.text ? node.text.replace(/\u00A0/g, ' ') : ''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiptap uses non breaking spaces between nodes (like variables). Those html characters are not properly handles in emails. Replacing by regular spaces during parsing.
I tried to fix it in settings but looks like this is only for preserving those nbsp and not for removal (see ueberdosis/tiptap#254)