Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor object metadata service #8123

Merged
merged 8 commits into from
Oct 28, 2024
Merged

Refactor object metadata service #8123

merged 8 commits into from
Oct 28, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Oct 27, 2024 •
edited
Loading

Context

ObjectMetadataService became quite large and handles too many responsibilities. I'm trying to refactor a bit this part in preparation of a larger work that will combine object-metadata services and sync-metadata logic

  • Created a STANDARD_OBJECT_ICONS that can be reused in relation creation to refer to a standard object icon.
  • Created a STANDARD_OBJECT_FIELD_IDS that can be used with an object name to get its standard field ids.
  • Moved migration, record and relation creations to dedicated services, refactored to improve performances and readability
  • Refactored some validation logic

@Weiko Weiko requested a review from charlesBochet October 27, 2024 15:20
@Weiko Weiko marked this pull request as ready for review October 28, 2024 09:43
@charlesBochet charlesBochet merged commit 28815f5 into main Oct 28, 2024
17 of 18 checks passed
@charlesBochet charlesBochet deleted the c--refactor-object-metadata-service branch October 28, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
-PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weiko @charlesBochet