Fix support custom object renaming #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
approved these changes
Oct 27, 2024
| @@ -102,6 +102,8 @@ const StyledLabel = styled.span` | |||
|
|
|||
| const infoCircleElementId = 'info-circle-id'; | |||
|
|
|||
| export const IS_LABEL_SYNCED_WITH_NAME_LABEL = 'isLabelSyncedWithName'; | |||
There was a problem hiding this comment.
Suggested change
| export const IS_LABEL_SYNCED_WITH_NAME_LABEL = 'isLabelSyncedWithName'; | |
| export const IS_LABEL_SYNCED_WITH_NAME = 'isLabelSyncedWithName'; |
| const shouldComputeNamesFromLabels: boolean = dirtyFieldKeys.includes( | ||
| IS_LABEL_SYNCED_WITH_NAME_LABEL, | ||
| ) | ||
| ? (formValues.isLabelSyncedWithName as boolean) |
There was a problem hiding this comment.
Suggested change
| ? (formValues.isLabelSyncedWithName as boolean) | |
| ? !!formValues.isLabelSyncedWithName |
or
Suggested change
| ? (formValues.isLabelSyncedWithName as boolean) | |
| ? (formValues.isLabelSyncedWithName ?? false) |
would be better than type assertion imho
| @@ -16,6 +16,7 @@ import { RecordFieldValueSelectorContextProvider } from '@/object-record/record- | |||
| import { SaveAndCancelButtons } from '@/settings/components/SaveAndCancelButtons/SaveAndCancelButtons'; | |||
| import { SettingsPageContainer } from '@/settings/components/SettingsPageContainer'; | |||
| import { | |||
| IS_LABEL_SYNCED_WITH_NAME_LABEL, | |||
There was a problem hiding this comment.
not 100% sure this const should be specifically owned by this component? Should we move to a constants folder instead?
Weiko
reviewed
Oct 27, 2024
| @@ -1641,4 +1635,18 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt | |||
| ); | |||
| } | |||
| }; | |||
|
|
|||
| private validateNameSingularAndNamePluralAreDifferentOrThrow = ( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR