101 featch available variables from previous steps #8062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martmull
force-pushed
the
101-featch-available-variables-from-previous-steps
branch
5 times, most recently
from
37c2513
to
c483f4c
Compare
martmull
force-pushed
the
101-featch-available-variables-from-previous-steps
branch
from
c483f4c
to
f89eee1
Compare
martmull
force-pushed
the
101-featch-available-variables-from-previous-steps
branch
from
8a8e8ef
to
450a397
Compare
thomtrp
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Great work 💪
Overall I wonder if we will not trigger too many calculation. The user may be playing with different nodes and we should not always generate the output schema. I start to wonder if we should not use a button to generate variables as ActivePieces and Windmill do...
packages/twenty-front/src/modules/workflow/hooks/useAvailableVariablesInWorkflowStep.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useAvailableVariablesInWorkflowStep.ts
Show resolved
Hide resolved
...enty-server/src/engine/core-modules/event-emitter/utils/generate-fake-object-record-event.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow.resolver.ts
Outdated
Show resolved
Hide resolved
|
@thomtrp I agree with your concern, think we can try like this and update the behavior in a future PR if necessary |
martmull
force-pushed
the
101-featch-available-variables-from-previous-steps
branch
from
642b6b6
to
f156c1a
Compare
thomtrp
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Ok so comments that will remain open:
- build available variables schema should be done on backend side
- computing step output schema should not happen on any update
Let's fix remaining comments and move on. We will test the feature like this and we will discuss with product how we can get a more efficient behavior in UI.
...enty-server/src/engine/core-modules/event-emitter/utils/generate-fake-object-record-event.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/workflow/services/workflow.service.ts
Outdated
Show resolved
Hide resolved
thomtrp
approved these changes
Oct 28, 2024
packages/twenty-server/src/engine/core-modules/workflow/resolvers/workflow.resolver.ts
Outdated
Show resolved
Hide resolved
|
Great job, @martmull! Your work is fantastic. |
martmull
deleted the
101-featch-available-variables-from-previous-steps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
demo.mov