Add padding to navigation header #8050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reesericci, it's strange that your PR works for me, but I can't reproduce the bug you encountered on the main branch. Are you using a specific setup, or do you notice anything that might trigger this bug? What browser are you using? |
|
Self hosted, Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0, unsure if there's a trigger |
|
Just seems like there was no padding on the header |
|
Thanks! After investigation, it works when there is a multi-workspace switcher, but it doesn't when there is only one connected workspace. Thanks for finding it! |
|
Gotcha |
martmull
approved these changes
Oct 28, 2024
Bonapara
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds padding to the header to align the logo with other icons on the sidebar.
Before
After