Text area using variables #8034
Conversation
| editorProps: { | ||
| handleKeyDown: (view, event) => { | ||
| if (event.key === 'Enter' && !event.shiftKey) { | ||
| event.preventDefault(); | ||
|
|
||
| const { state } = view; | ||
| const { tr } = state; | ||
|
|
||
| // Insert hard break using the view's state and dispatch | ||
| const transaction = tr.replaceSelectionWith( | ||
| state.schema.nodes.hardBreak.create(), | ||
| ); | ||
|
|
||
| view.dispatch(transaction); | ||
|
|
||
| return true; | ||
| } | ||
| return false; | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Why do we implement that logic? It seems that Tiptap should handle it, shouldn't it?
There was a problem hiding this comment.
Tip tap does not perform hardbreak on Enter. The behavior is not great by default
| }, | ||
| }, | ||
| enableInputRules: false, | ||
| enablePasteRules: false, |
There was a problem hiding this comment.
Does it have something to do with the fact that we can't copy and paste from other <VariableTagInput /> components and get the variables correctly wired? I'm not saying that we absolutely want that behavior, I'm just wondering what problem you solved by disabling enabledPasteRules.
CleanShot.2024-10-25.at.11.02.14.mp4
There was a problem hiding this comment.
I am not sure. Tiptap by default enable a lot of features that we do not need. Following the doc, their recommendation is for exemple to use a StarterKit for several extensions. And enabling input and paste rules that I did not fully understand https://tiptap.dev/docs/editor/extensions/custom-extensions/extend-existing#paste-rules. By default I prefer removing these and put back only the ones I need later.
But to answer your video, no, the behavior si the same with or without those paste rules
There was a problem hiding this comment.
Okay! Great! I agree with you 💯
thomtrp
force-pushed
the
tt-text-area-tag-variables
branch
from
43283fa
to
4e80dab
Compare
thomtrp
force-pushed
the
tt-text-area-tag-variables
branch
from
4e80dab
to
1e252f4
Compare
thomtrp
force-pushed
the
tt-text-area-tag-variables
branch
from
1e252f4
to
db4b0df
Compare
Enregistrement.de.l.ecran.2024-10-24.a.17.07.14.mov