Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent workflow right drawer flickering when selecting an action type #8028

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Devessier
Copy link
Contributor

In this PR:

  • Use a stable id for create-step nodes; it makes it possible to preserve their selected attribute and keep them open even after the flow is re-generated
  • Preemptively open the WorkflowStepEdit right drawer for the created action
CleanShot.2024-10-24.at.13.24.03.mp4

Fixes https://github.com/twentyhq/private-issues/issues/123

Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work!

@Devessier Devessier merged commit e44d525 into main Oct 24, 2024
18 checks passed
@Devessier Devessier deleted the prevent-workflow-right-drawer-flickering branch October 24, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants