Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relation picker should not move once openened #8026

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

harshrajeevsingh
Copy link
Contributor

Fixes: #7959

Problem

  • When searching in the dropdown, the results list would shrink based on matching items
  • This dynamic height change caused the dropdown to flip its position on each keystroke

Solution

  • Added hasMinHeight as optional props to the DropdownMenuItemsContainer to maintain consistent height
  • This prevents unwanted position recalculations and flipping while user types
  • The dropdown now stays in its initial position throughout the search interaction
Screencast.from.2024-10-24.15-43-03.webm

@FelixMalfait FelixMalfait self-assigned this Oct 24, 2024
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks!

@FelixMalfait
Copy link
Member

/award 450

Copy link

oss-gg bot commented Oct 24, 2024

Awarding harshrajeevsingh: 450 points 🕹️ Well done! Check out your new contribution on oss.gg/harshrajeevsingh

@FelixMalfait FelixMalfait merged commit 4e8d8ce into twentyhq:main Oct 24, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relation should not move once openened
2 participants