-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Manual Triggers #8024
Add Manual Triggers #8024
Conversation
…and disableTrigger functions
…rs to support manual triggers
460d1fc
to
a3e8dc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey nice work! I have left some comments about naming. I might be wrong so don't hesitate to answer my comments. We can discuss that also with pleasure!
}> = [ | ||
{ | ||
label: 'When record(s) are selected', | ||
value: 'WHEN_RECORD_SELECTED', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use an enum for record values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlesBochet told me a few times that we use string type unions in the frontend, not enums. That's why I always do it that way 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhh, ok why @charlesBochet?
type: 'MANUAL'; | ||
settings: | ||
| { | ||
availability: 'EVERYWHERE'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then you can use enum values everywhere
In this PR:
CleanShot.2024-10-24.at.14.11.45.mp4