Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manual Triggers #8024

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Add Manual Triggers #8024

merged 12 commits into from
Oct 25, 2024

Conversation

Devessier
Copy link
Contributor

@Devessier Devessier commented Oct 24, 2024

In this PR:

  • Add support for manual triggers in the backend
  • Add a right drawer to let users select the type of trigger they want
  • Create a specific right drawer for database event triggers
  • Create a right drawer for manual triggers; let the user select where the manual trigger should be made available
  • Create a default trigger as soon as the user selects the type of trigger they want. It prevents the user to see empty selects for record type and event type. By default, the database event trigger will be set to "company.created". It should be visible enough for users to understand what happens and choose another record type or event type.
CleanShot.2024-10-24.at.14.11.45.mp4

@Devessier Devessier force-pushed the create-manual-triggers branch from 460d1fc to a3e8dc4 Compare October 24, 2024 10:10
@Devessier Devessier marked this pull request as ready for review October 24, 2024 12:22
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice work! I have left some comments about naming. I might be wrong so don't hesitate to answer my comments. We can discuss that also with pleasure!

}> = [
{
label: 'When record(s) are selected',
value: 'WHEN_RECORD_SELECTED',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use an enum for record values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlesBochet told me a few times that we use string type unions in the frontend, not enums. That's why I always do it that way 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mhh, ok why @charlesBochet?

type: 'MANUAL';
settings:
| {
availability: 'EVERYWHERE';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then you can use enum values everywhere

@Devessier Devessier merged commit 0144553 into main Oct 25, 2024
18 checks passed
@Devessier Devessier deleted the create-manual-triggers branch October 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants