Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server Integration tests] Enrich integration GraphQL API tests #4 #8015

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Oct 23, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-7526.


Description

We are using standard field and object IDs because there is a problem when creating them as we would with helpers.

We were creating custom objects and removing them in afterAll, but there is a problem that causes a conflict in the object IDs if the tests run at the same time. The solution would be to modify the test command as mentioned here:

typeorm/typeorm#6125

Currently, we are using the standard IDs but we can create the objects within the test if you want, but we would need to make them run in sequence

Demo

Refs

#7526

@gitstart-twenty
Copy link
Contributor

Hello @charlesBochet 👋
The tests are failing on the CI but we can not debug since there are no logs from the jest, we are not sure if It's related to what we mentioned in the description, because locally is working fine.
Could you tell us your preference about what we mentioned in the description? Then we can push the related changes, and check if the error persists. If we don't need to change anything, could you provide some information on how to debug this problem in CI?

@charlesBochet charlesBochet merged commit f202cdb into main Oct 28, 2024
18 checks passed
@charlesBochet charlesBochet deleted the TWNTY-7526-4 branch October 28, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants