Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to twenty-ui - layout/card #8003

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Migrate to twenty-ui - layout/card #8003

merged 3 commits into from
Oct 24, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Oct 23, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-7532.


Description

Migrate:

  • Card
  • CardContent
  • CardFooter
  • CardHeader

Demo

Card in Storybook

Fixes twentyhq/private-issues#86

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request focuses on migrating various components to use the new 'twenty-ui' library for card-related components.

  • Migrated Card, CardContent, CardFooter, and CardHeader components from local imports to 'twenty-ui' library
  • Updated import statements across multiple files in settings, activities, and data model modules
  • Moved Card component implementation from twenty-front package to twenty-ui package
  • Maintained existing functionality and styling of components while standardizing UI component usage
  • Ensured backward compatibility and consistent behavior across the application

30 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines 3 to 7
import {
SettingsDataModelFieldPreview,
// eslint-disable-next-line prettier/prettier
SettingsDataModelFieldPreview,
SettingsDataModelFieldPreviewProps,
} from '@/settings/data-model/fields/preview/components/SettingsDataModelFieldPreview';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider removing the eslint-disable comment and fixing the prettier issue instead

@charlesBochet charlesBochet merged commit 1dfeba3 into main Oct 24, 2024
17 of 18 checks passed
@charlesBochet charlesBochet deleted the TWNTY-7532 branch October 24, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants