Migrate to twenty-ui - feedback/progress-bar #8002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gitstart-app[bot]](https://avatars.githubusercontent.com/in/46283?s=60&v=4){kind=small}
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request migrates the CircularProgressBar and ProgressBar components from the local UI folder to the twenty-ui library, ensuring consistent functionality across the codebase.
- Updated import statements in multiple files to use 'twenty-ui' for CircularProgressBar and ProgressBar
- Moved CircularProgressBar.tsx and ProgressBar.tsx to packages/twenty-ui/src/feedback/progress-bar/components/
- Added new index.ts file in packages/twenty-ui/src/feedback/ to export progress bar components
- Updated Storybook stories for CircularProgressBar and ProgressBar in twenty-ui package
- Removed duplicate Button component export in packages/twenty-front/tsup.ui.index.tsx
12 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -23,6 +21,7 @@ export * from './src/modules/ui/input/components/IconPicker'; | |||
| export * from './src/modules/ui/input/components/ImageInput'; | |||
| export * from './src/modules/ui/input/components/Radio'; | |||
| export * from './src/modules/ui/input/components/RadioGroup'; | |||
| export * from './src/modules/ui/input/button/components/Button'; | |||
There was a problem hiding this comment.
syntax: Remove this duplicate export of Button component
charlesBochet
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by GitStart to address the requirements from this ticket: TWNTY-7527.
Description
Migrate
feedback/progress-barto twenty ui:Demo
ProgressBar on Storybook
CircularProgressBar on Storybook
Fixes twentyhq/private-issues#91