7339 implement contextual actions inside the commandmenu #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
reviewed
Oct 24, 2024
packages/twenty-front/src/modules/command-menu/components/CommandMenuActions.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/command-menu/components/CommandMenuActions.tsx
Outdated
Show resolved
Hide resolved
...ront/src/modules/action-menu/actions/record-actions/components/DeleteRecordsActionEffect.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Outdated
Show resolved
Hide resolved
.../src/modules/action-menu/actions/record-actions/components/RecordActionMenuEntriesSetter.tsx
Outdated
Show resolved
Hide resolved
| @@ -43,5 +48,11 @@ export const RecordIndexActionMenuEffect = () => { | |||
| isDropdownOpen, | |||
| ]); | |||
|
|
|||
| useEffect(() => { | |||
| if (isRightDrawerOpen || isCommandMenuOpened) { | |||
| closeActionBar(); | |||
There was a problem hiding this comment.
move to openCommandMenu() and useOpenRightdrawer()
There was a problem hiding this comment.
This is done this way because multiple action bars could be opened simultaneously and since these are component states we can't know which ones we should close. To do that, we would need another state to store the active action menus.
packages/twenty-front/src/modules/action-menu/states/contexts/ActionMenuContext.ts
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Oct 29, 2024
charlesBochet
deleted the
7339-implement-contextual-actions-inside-the-commandmenu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7339
Enregistrement.de.l.ecran.2024-10-23.a.15.54.00.mov