Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to twenty-ui - feedback/loader #7997

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Migrate to twenty-ui - feedback/loader #7997

merged 4 commits into from
Oct 24, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Oct 23, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-7528.


Description

  • Move loader components to twenty-ui

Fixes twentyhq/private-issues#90

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR migrates the Loader component from local implementations to the twenty-ui package, affecting multiple files across the project.

  • Moved Loader component to packages/twenty-ui/src/feedback/loader/components/Loader.tsx
  • Updated import statements in various components to use Loader from 'twenty-ui'
  • Added export for feedback module in packages/twenty-ui/src/index.ts
  • Maintained existing functionality and styling of the Loader component
  • Aligned with project goal of centralizing UI components for better maintainability

10 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlesBochet charlesBochet merged commit 4ceee4a into main Oct 24, 2024
17 of 18 checks passed
@charlesBochet charlesBochet deleted the TWNTY-7528 branch October 24, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants