Add shortcut metadata to data models & CommandMenu

[florianliebig]

Resolves #7503

[greptile-apps]

PR Summary

This pull request removes hotkeys for custom object commands in the command menu, addressing the issue of conflicting shortcuts for objects with the same first letter.

• Modified GotoHotkeysEffectsProvider.tsx to skip creating hotkeys for custom objects
• Updated useCommandMenu.ts to set firstHotKey and secondHotKey as undefined for custom objects
• Added a new test case in useCommandMenu.test.tsx to verify that custom objects don't receive hotkeys
• These changes improve the command menu's object list by preventing shortcut conflicts and streamlining navigation

_{3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

syntax: 'hokey' is misspelled. Should be 'hotkey'

Suggested change

	key={`go-to-hokey-item-${objectMetadataItem.id}`}
	key={`go-to-hotkey-item-${objectMetadataItem.id}`}

[florianliebig]

Was wrong before, should I fix it in this scope?

[FelixMalfait]

That'd be great thanks!

[florianliebig]

Changed

[FelixMalfait]

Thanks for creating a test! Could you please pick another name for the custom object? Like Rocket or whatever you want. Because Task is a standard object so it can be misleading

[florianliebig]

Changed

[FelixMalfait]

/award 150

[oss-gg]

Awarding florianliebig: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/florianliebig

[FelixMalfait]

I realize we still have an issue with the new standard objects we've just introduced :'(

I didn't expect this to happened so early....

We might have to go through the hard route and introduce a shortcut field on the backend / get it from there :/

[florianliebig]

@FelixMalfait jeah saw that, too... for me as a user, I would say only frequently used items should need a hotkey - not all. So hardcoding that might be most suitable

[FelixMalfait]

I tried to do the backend part quickly to help you :), not fully tested but it should work hopefuly! Do you want to take over and redo the frontend?

The goal is to be able to access the .shortcut property directly on the object's metadata

[florianliebig]

Thanks, can take over @FelixMalfait - some questions for the UI / UX of it:

My idea was to place it here - or is that too tight? Could also create a new section at the settings.

Do we want to allow to edit the shortcuts for the non-custom objects, too? Then we would need to add another form anyways as the existing one is disabled for those.

[FelixMalfait]

Oh nice you want to display it in settings, I didn't even think we'd do that.

cc @Bonapara what do you think?

[florianliebig]

@FelixMalfait Also having a hard time getting the query ObjectMetadataItems in generated gql.ts updated. Field is now missing in the response, even though I added it in many places and ran nx graphql:generate twenty-front

[FelixMalfait]

@florianliebig I might have forgotten something in the backend then! you can check in the graphql console: https://twenty.com/developers/graphql/metadata ; I'll check this afternoon and let you know

Did you update the FIND_MANY_OBJECT_METADATA_ITEMS query?

[Bonapara]

@florianliebig thanks for your PR! It's a great fix.

For the front-end, I think placing them in the settings is a great idea, but we should wait a bit before doing that: I would love to introduce a shortcut tab in the settings and need to consider its behavior. So let's fix the backend first, and I'll create an issue for the front-end soon!

Thanks a lot for contributing ;)

[florianliebig]

Thanks for the support @FelixMalfait - I can finish it up with some tests if you like

[FelixMalfait]

Thanks a lot @florianliebig great work! feel free to raise a PR on adding a test or on any other issue, happy to support you if you're stuck :)