Chip right height according to view #7976
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces size adjustments for the AvatarChip component to improve visual consistency across different view types, particularly for Kanban and list views.
- Added
sizeprop toAvatarChipinpackages/twenty-ui/src/display/chip/components/AvatarChip.tsx - Modified
RecordIndexRecordChipinpackages/twenty-front/src/modules/object-record/record-index/components/RecordIndexRecordChip.tsxto setChipSize.Largefor Kanban view - Updated
Chipcomponent inpackages/twenty-ui/src/display/chip/components/Chip.tsxto adjust height based onsizeprop - Simplified
OverflowingTextWithTooltipusage inChipcomponent by directly passing thesizeprop
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -17,6 +20,7 @@ export const RecordIdentifierChip = ({ | |||
| variant, | |||
| }: RecordIdentifierChipProps) => { | |||
| const { onIndexIdentifierClick } = useContext(RecordIndexRootPropsContext); | |||
| const recordIndexViewType = useRecoilValue(recordIndexViewTypeState); | |||
There was a problem hiding this comment.
It feels like it would be cleaner to pass introduce size in this component and pass the chip size from the level right above, similar what we probably do with variant no? Can't tell exactly why but it feels a bit odd here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.