Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache storage #7966

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix cache storage #7966

merged 1 commit into from
Oct 22, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Oct 22, 2024

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request simplifies the Redis cache setup in the cache storage module by utilizing a Redis URL instead of a separate Redis client service.

  • Removed RedisClientService dependency from cache-storage.module-factory.ts and cache-storage.module.ts
  • Added check for REDIS_URL environment variable in cache-storage.module-factory.ts
  • Modified Redis cache configuration to use REDIS_URL directly in cache-storage.module-factory.ts
  • Simplified CacheStorageModule dependencies while maintaining Redis support

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 6c93587 into main Oct 22, 2024
18 checks passed
@charlesBochet charlesBochet deleted the c--fix-cache-storage branch October 22, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants