Add skip option at invite team step #7960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request adds a 'Skip' option to the InviteTeam component during the onboarding process, addressing issue #5925.
- Added a styled container
StyledActionSkipLinkContainerfor the skip link in/packages/twenty-front/src/pages/onboarding/InviteTeam.tsx - Implemented an
ActionLinkcomponent with "Skip" text, allowing users to bypass team invitation - Integrated skip functionality with existing
onSubmithandler, passing an empty email list - Added a
keyprop toRecordBoardColumnHeaderWrapperin/packages/twenty-front/src/modules/object-record/record-board/components/RecordBoardHeader.tsxfor React optimization
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
227
to
229
| onClick={handleSubmit(async () => { | ||
| await onSubmit({ emails: [] }); | ||
| })} |
There was a problem hiding this comment.
style: Consider extracting this logic into a separate function for better readability and reusability
Suggested change
| onClick={handleSubmit(async () => { | |
| await onSubmit({ emails: [] }); | |
| })} | |
| const handleSkip = async () => { | |
| await onSubmit({ emails: [] }); | |
| }; | |
| <...> | |
| <ActionLink onClick={handleSubmit(handleSkip)}>Skip</ActionLink> |
ijreilly
commented
Oct 22, 2024
| @@ -27,7 +27,7 @@ export const RecordBoardHeader = () => { | |||
| return ( | |||
| <StyledHeaderContainer id="record-board-header"> | |||
| {columnIds.map((columnId) => ( | |||
| <RecordBoardColumnHeaderWrapper columnId={columnId} /> | |||
| <RecordBoardColumnHeaderWrapper columnId={columnId} key={columnId} /> | |||
There was a problem hiding this comment.
unrelated but needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #5925